-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
STY: standardize spacing for casting, with linting #23474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
prob should put all of these rules into a flake-cython package :)
If we can find someone else to maintain it, that'd be fantastic. |
Codecov Report
@@ Coverage Diff @@
## master #23474 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 161 161
Lines 51197 51197
=======================================
Hits 47220 47220
Misses 3977 3977
Continue to review full report at Codecov.
|
Not for this PR, but a couple of other patterns that would be relatively easy to lint for:
For these purposes (and for this PR) we just assume away comments and docstrings. |
Thanks @jbrockmendel, nice addition. There are reasons for having it with both the linting and the patters, happy with any. |
Casting in cython is done with the syntax
<type>obj
or<type> obj
. ATM the code uses both of these. This PR standardizes on the first usage, with a lint check.@datapythonista I'm not sure whether the grep check here belongs in the patterns section or in the non-python section. LMK if you have a preference.