Skip to content

feat: Add support for encoding parameter on read_excel #23448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mau21mau
Copy link

@mau21mau mau21mau commented Nov 1, 2018

@pep8speaks
Copy link

pep8speaks commented Nov 1, 2018

Hello @mau21mau! Thanks for updating the PR.

Comment last updated on November 05, 2018 at 14:00 Hours UTC

@gfyoung gfyoung added Enhancement IO Excel read_excel, to_excel labels Nov 1, 2018
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would absolutely need a test

@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #23448 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23448      +/-   ##
==========================================
+ Coverage   92.22%   92.23%   +<.01%     
==========================================
  Files         161      161              
  Lines       51191    51197       +6     
==========================================
+ Hits        47210    47220      +10     
+ Misses       3981     3977       -4
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 42.27% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/timedeltas.py 93.75% <0%> (-0.56%) ⬇️
pandas/util/testing.py 86.64% <0%> (-0.2%) ⬇️
pandas/core/indexes/base.py 96.46% <0%> (-0.16%) ⬇️
pandas/core/arrays/datetimelike.py 96.1% <0%> (-0.06%) ⬇️
pandas/core/indexes/datetimes.py 96.41% <0%> (-0.03%) ⬇️
pandas/core/indexes/datetimelike.py 98.01% <0%> (-0.01%) ⬇️
pandas/core/indexes/api.py 99% <0%> (ø) ⬆️
pandas/core/frame.py 97.03% <0%> (ø) ⬆️
pandas/core/generic.py 96.81% <0%> (ø) ⬆️
pandas/core/series.py 93.87% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9318c...077efe7. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Dec 3, 2018

this needs tests, also pls merge master

@jreback
Copy link
Contributor

jreback commented Dec 23, 2018

needs tests. ping if you want to keep working.

@jreback jreback closed this Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'ascii' codec can't decode byte 0xd1 in position 2: ordinal not in range(128)
4 participants