Skip to content

CI: Move durations to pytest call #23434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

TomAugspurger
Copy link
Contributor

Having it in the setup.cfg meant it was used with doctests, which
pushed errors further from the exit code.

Having it in the setup.cfg meant it was used with doctests, which
pushed errors further from the exit code.
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Oct 31, 2018
@gfyoung gfyoung added Docs CI Continuous Integration labels Oct 31, 2018
@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #23434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23434   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         161      161           
  Lines       51173    51173           
=======================================
  Hits        47190    47190           
  Misses       3983     3983
Flag Coverage Δ
#multiple 90.65% <ø> (ø) ⬆️
#single 42.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de39bfc...ee7d86c. Read the comment docs.

@jbrockmendel
Copy link
Member

Would it make sense to override in the doctest command rather than repeat in all the others?

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Oct 31, 2018 via email

@jreback jreback merged commit 9c17300 into pandas-dev:master Oct 31, 2018
@jreback
Copy link
Contributor

jreback commented Oct 31, 2018

thanks, this makes sense

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants