Skip to content

BUG: Respect axis when doing DataFrame.expanding #23402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Oct 29, 2018

Closes #23372.

@gfyoung gfyoung added Bug Window rolling, ewma, expanding labels Oct 29, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Oct 29, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #23402 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23402      +/-   ##
==========================================
- Coverage   92.21%   92.19%   -0.03%     
==========================================
  Files         161      161              
  Lines       51173    51192      +19     
==========================================
+ Hits        47190    47194       +4     
- Misses       3983     3998      +15
Flag Coverage Δ
#multiple 90.62% <100%> (-0.03%) ⬇️
#single 42.22% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/core/window.py 96.4% <100%> (ø) ⬆️
pandas/core/arrays/datetimelike.py 94.01% <0%> (-2.11%) ⬇️
pandas/core/indexes/period.py 91.04% <0%> (-1.12%) ⬇️
pandas/core/dtypes/base.py 100% <0%> (ø) ⬆️
pandas/core/dtypes/missing.py 93.1% <0%> (ø) ⬆️
pandas/core/dtypes/inference.py 98.38% <0%> (ø) ⬆️
pandas/core/dtypes/dtypes.py 95.61% <0%> (ø) ⬆️
pandas/core/dtypes/common.py 94.37% <0%> (ø) ⬆️
pandas/core/dtypes/cast.py 88.92% <0%> (ø) ⬆️
pandas/core/dtypes/concat.py 96.34% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de39bfc...6b28995. Read the comment docs.

@gfyoung gfyoung force-pushed the df-expanding-axis-arg branch from 6470a1a to b66ba5a Compare October 30, 2018 20:57
@gfyoung
Copy link
Member Author

gfyoung commented Oct 30, 2018

@jreback : Addressed feedback, and all is green. PTAL.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. minor comments.

@gfyoung gfyoung force-pushed the df-expanding-axis-arg branch from b66ba5a to 6b28995 Compare October 31, 2018 17:25
@gfyoung
Copy link
Member Author

gfyoung commented Oct 31, 2018

@jreback : All comments addressed, and everything is green. PTAL.

@jreback jreback merged commit 3b50d94 into pandas-dev:master Nov 1, 2018
@jreback
Copy link
Contributor

jreback commented Nov 1, 2018

nice! thanks @gfyoung

@gfyoung gfyoung deleted the df-expanding-axis-arg branch November 1, 2018 00:40
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants