-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Respect axis when doing DataFrame.expanding #23402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @gfyoung! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23402 +/- ##
==========================================
- Coverage 92.21% 92.19% -0.03%
==========================================
Files 161 161
Lines 51173 51192 +19
==========================================
+ Hits 47190 47194 +4
- Misses 3983 3998 +15
Continue to review full report at Codecov.
|
6470a1a
to
b66ba5a
Compare
@jreback : Addressed feedback, and all is green. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. minor comments.
b66ba5a
to
6b28995
Compare
@jreback : All comments addressed, and everything is green. PTAL. |
nice! thanks @gfyoung |
Closes #23372.