Skip to content

Fix import format pandas/tests/indexing #23351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2018

Conversation

amphy
Copy link
Contributor

@amphy amphy commented Oct 26, 2018

Ran isort --recursive pandas and then checked imports using isort --recursive --check-only pandas

PR capped at 20 files, but 21 files changed because it includes setup.cfg which has also been changed.

@pep8speaks
Copy link

Hello @amphy! Thanks for submitting the PR.

@jreback jreback added the Code Style Code style, linting, code_checks label Oct 26, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 26, 2018
@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

lgtm. ping on green.

@thoo
Copy link
Contributor

thoo commented Oct 26, 2018

@amphy Do you have to rerun isort? I still have issue travis-ci. And I also saw you had before.

@amphy
Copy link
Contributor Author

amphy commented Oct 26, 2018

@thoo Yeah, I re-ran isort after checking the pandas/tests/indexing directory again with isort and it seems to pass what was giving me trouble earlier with Travis CI (My issue was that I was getting an error from ./ci/code_checks.sh so I ran that locally which revealed that I was getting some errors from isort)

@thoo
Copy link
Contributor

thoo commented Oct 26, 2018

@amphy I looked at your log before and we are getting the same error. I have 3-4 commits with similar errors. I think it might be related to rebasing with upstream/master. Thanks for the reply. Hopefully it will solve.

@thoo
Copy link
Contributor

thoo commented Oct 26, 2018

@amphy Thanks. Mine is fixed too.

@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #23351 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23351      +/-   ##
==========================================
+ Coverage   92.22%   92.22%   +<.01%     
==========================================
  Files         169      169              
  Lines       51258    51261       +3     
==========================================
+ Hits        47274    47277       +3     
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.66% <ø> (ø) ⬆️
#single 42.23% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/series.py 93.91% <0%> (-0.01%) ⬇️
pandas/core/arrays/sparse.py 91.84% <0%> (ø) ⬆️
pandas/core/arrays/datetimes.py 97.46% <0%> (ø) ⬆️
pandas/core/dtypes/cast.py 89.28% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437f31c...8f654d5. Read the comment docs.

@amphy
Copy link
Contributor Author

amphy commented Oct 27, 2018

@jreback All green now

@jreback jreback merged commit 4cc76c2 into pandas-dev:master Oct 28, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants