-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix import format pandas/tests/indexing #23351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @amphy! Thanks for submitting the PR.
|
lgtm. ping on green. |
@amphy Do you have to rerun |
@thoo Yeah, I re-ran isort after checking the pandas/tests/indexing directory again with isort and it seems to pass what was giving me trouble earlier with Travis CI (My issue was that I was getting an error from ./ci/code_checks.sh so I ran that locally which revealed that I was getting some errors from isort) |
@amphy I looked at your log before and we are getting the same error. I have 3-4 commits with similar errors. I think it might be related to rebasing with upstream/master. Thanks for the reply. Hopefully it will solve. |
@amphy Thanks. Mine is fixed too. |
Codecov Report
@@ Coverage Diff @@
## master #23351 +/- ##
==========================================
+ Coverage 92.22% 92.22% +<.01%
==========================================
Files 169 169
Lines 51258 51261 +3
==========================================
+ Hits 47274 47277 +3
Misses 3984 3984
Continue to review full report at Codecov.
|
@jreback All green now |
git diff upstream/master -u -- "*.py" | flake8 --diff
Ran
isort --recursive pandas
and then checked imports usingisort --recursive --check-only pandas
PR capped at 20 files, but 21 files changed because it includes setup.cfg which has also been changed.