Skip to content

Fix import format tests/indexes/ "Part One" #23337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

thoo
Copy link
Contributor

@thoo thoo commented Oct 25, 2018

PR is capped at 20 files. So this is not all the files modified from pandas/tests/indexes/. So this is Part One of this directory pandas/tests/indexes/.

@pep8speaks
Copy link

Hello @thoo! Thanks for submitting the PR.

@thoo thoo force-pushed the fix_import_format branch from 7029ca1 to cfb7958 Compare October 25, 2018 21:26
@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #23337 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23337      +/-   ##
==========================================
- Coverage   92.22%   92.22%   -0.01%     
==========================================
  Files         169      169              
  Lines       51261    51259       -2     
==========================================
- Hits        47277    47273       -4     
- Misses       3984     3986       +2
Flag Coverage Δ
#multiple 90.66% <ø> (-0.01%) ⬇️
#single 42.23% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 86.64% <0%> (-0.2%) ⬇️
pandas/core/dtypes/cast.py 89.22% <0%> (-0.06%) ⬇️
pandas/core/arrays/datetimes.py 97.45% <0%> (-0.01%) ⬇️
pandas/core/groupby/ops.py 96.79% <0%> (ø) ⬆️
pandas/core/groupby/base.py 91.83% <0%> (ø) ⬆️
pandas/core/arrays/sparse.py 91.84% <0%> (ø) ⬆️
pandas/core/groupby/grouper.py 98.16% <0%> (ø) ⬆️
pandas/core/groupby/groupby.py 96.48% <0%> (ø) ⬆️
pandas/core/groupby/categorical.py 95.45% <0%> (ø) ⬆️
pandas/core/series.py 93.91% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e45ed...ac6a495. Read the comment docs.

@jreback jreback added the Code Style Code style, linting, code_checks label Oct 26, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 26, 2018
@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

@thoo pls remove the fixed files from the setup.cfg as then the flaker will check.

@thoo
Copy link
Contributor Author

thoo commented Oct 26, 2018

Sorry. I missed that part.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping on green.

@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

btw, since lots of these PR's, any time you push merge in master as well.

@thoo thoo force-pushed the fix_import_format branch from d23a6d9 to b947697 Compare October 26, 2018 00:16
@thoo
Copy link
Contributor Author

thoo commented Oct 26, 2018

@jreback Pass all checks.

@jreback jreback closed this Oct 28, 2018
@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

i think this was duplicated somehow.

@thoo thoo deleted the fix_import_format branch January 2, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants