-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: isort imports- util dir #23331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: isort imports- util dir #23331
Conversation
Hello @alimcmaster1! Thanks for submitting the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm if green
Any chance a core dev - could restart the 3.6 build on Travis. ( Or grant me the relevant permission so I can do this myself going forward - happy to discuss this offline if appropriate ) I seem to be getting this: |
Restarted. LMK if it times out again and I'll take a closer look. |
Codecov Report
@@ Coverage Diff @@
## master #23331 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 161 161
Lines 51184 51184
=======================================
Hits 47185 47185
Misses 3999 3999
Continue to review full report at Codecov.
|
pls merge master. and ping on green. |
needs another merge of master |
pandas/util/testing.py
Outdated
|
||
# pylint: disable-msg=W0402 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this here?
pandas/lib.py
Outdated
@@ -1,8 +1,10 @@ | |||
# flake8: noqa | |||
|
|||
import warnings | |||
|
|||
from pandas._libs.lib import * | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove the deprecated ones they are being removed elsewhere
can you merge master, we just updated the isort cfg |
ping - @jreback merged master and now green |
thanks @alimcmaster1 keep em coming! |
Thanks @jreback !
…On Tue, 30 Oct 2018 at 12:25, Jeff Reback ***@***.***> wrote:
Merged #23331 <#23331> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23331 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AP9Vsnc-rr87IAlohDK8uYQJgjvofx5vks5uqEUhgaJpZM4X6r_5>
.
|
Signed-off-by: alimcmaster1 [email protected]
util directory/.py files in pandas directory.
git diff upstream/master -u -- "*.py" | flake8 --diff