Skip to content

CLN: isort imports- util dir #23331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2018
Merged

CLN: isort imports- util dir #23331

merged 5 commits into from
Oct 30, 2018

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 commented Oct 25, 2018

Signed-off-by: alimcmaster1 [email protected]

util directory/.py files in pandas directory.

@pep8speaks
Copy link

Hello @alimcmaster1! Thanks for submitting the PR.

@alimcmaster1 alimcmaster1 changed the title CLN: isort imports CLN: isort imports- util dir Oct 25, 2018
@WillAyd WillAyd added the Clean label Oct 25, 2018
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if green

@alimcmaster1
Copy link
Member Author

Any chance a core dev - could restart the 3.6 build on Travis. ( Or grant me the relevant permission so I can do this myself going forward - happy to discuss this offline if appropriate )

I seem to be getting this:
The job exceeded the maximum time limit for jobs, and has been terminated

@TomAugspurger
Copy link
Contributor

Restarted. LMK if it times out again and I'll take a closer look.

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #23331 into master will not change coverage.
The diff coverage is 96.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23331   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         161      161           
  Lines       51184    51184           
=======================================
  Hits        47185    47185           
  Misses       3999     3999
Flag Coverage Δ
#multiple 90.62% <96.77%> (ø) ⬆️
#single 42.23% <96.77%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/_depr_module.py 0% <0%> (ø) ⬆️
pandas/util/_doctools.py 12.87% <100%> (ø) ⬆️
pandas/util/_decorators.py 91.34% <100%> (ø) ⬆️
pandas/util/_print_versions.py 15.71% <100%> (ø) ⬆️
pandas/util/testing.py 86.84% <100%> (ø) ⬆️
pandas/util/_test_decorators.py 93.24% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e5994...7baa169. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Oct 26, 2018
@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

pls merge master. and ping on green.

@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

needs another merge of master


# pylint: disable-msg=W0402
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this here?

pandas/lib.py Outdated
@@ -1,8 +1,10 @@
# flake8: noqa

import warnings

from pandas._libs.lib import *

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the deprecated ones they are being removed elsewhere

@jreback
Copy link
Contributor

jreback commented Oct 29, 2018

can you merge master, we just updated the isort cfg

@alimcmaster1
Copy link
Member Author

ping - @jreback merged master and now green

@jreback jreback merged commit da9e358 into pandas-dev:master Oct 30, 2018
@jreback
Copy link
Contributor

jreback commented Oct 30, 2018

thanks @alimcmaster1 keep em coming!

@alimcmaster1
Copy link
Member Author

alimcmaster1 commented Oct 30, 2018 via email

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants