TST: Condense tests in test_interval_new.py and add new test based on TODO #23275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
added
Testing
jschendel
commented
Oct 22, 2018
| @@ -12,13 +12,6 @@ | |||
|
|
|||
| class TestIntervalIndex(object): | |||
|
|
|||
| def _compare_tuple_of_numpy_array(self, result, expected): | |||
jschendel
force-pushed
the
ii-new-tests-clean
branch
from
1d68add to
5ec2432
Compare
|
Hello @jschendel! Thanks for submitting the PR.
|
|
thanks! |
JustinZhengBC
pushed a commit
to JustinZhengBC/pandas
that referenced
this pull request
Oct 23, 2018
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffCombined a some pairs of similar tests into single tests, e.g.
test_get_indexer_with_interval_multiple_queriesandtest_get_indexer_with_interval_single_queriesare essentially testing the same functionality but with different input toget_indexer, so just needed a couple of superficial changes to combine into a single test.I also added one test based on a TODO,
test_get_indexer_errors, which verifies thatget_indexerraises if theIntervalIndexis overlapping. Note that this is consistent withget_indexerraising for other indexes if the index is non-unique; for intervals uniqueness is not enough to ensure unique query results, as a scalar query against an overlappingIntervalIndexcan return non-unique indices.I've got all these tests to pass on my WIP branch implementing the new behavior, with the exception of the
slice_locstests, so will hopefully have a PR for that soon.