-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Updated the docstring of Series.rank / DataFrame.rank #23263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @EdAbati! Thanks for submitting the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comments, there are pep8 issues in all the examples.
Codecov Report
@@ Coverage Diff @@
## master #23263 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 161 161
Lines 51339 51339
=======================================
Hits 47360 47360
Misses 3979 3979
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @EdAbati, I was checking the examples in more detail, and for me doesn't make it very easy to understand what rank
does. Added some comments on how I think we could make them more clear. But fix them in a way that they make sense for you, and that they would be useful for you if you wanted to learn what rank
does and you didn't know already.
@EdAbati do you have time to update this PR? |
ping @datapythonista |
Closing as stale, @EdAbati let us know if you want to continue working on it. |
Hi @datapythonista, Extremely sorry for the delay. |
Hi @datapythonista , I gave it another try. |
git diff upstream/master -u -- "*.py" | flake8 --diff
I have updated the docstring following the convention and I have added some examples.
Please let me know if I can further improve this.
Thanks