Skip to content

DOC: Updated the docstring of Series.rank / DataFrame.rank #23263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

EdAbati
Copy link
Contributor

@EdAbati EdAbati commented Oct 21, 2018

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

I have updated the docstring following the convention and I have added some examples.

Please let me know if I can further improve this.

Thanks

@pep8speaks
Copy link

Hello @EdAbati! Thanks for submitting the PR.

@jschendel jschendel added the Docs label Oct 21, 2018
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission!

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comments, there are pep8 issues in all the examples.

@codecov
Copy link

codecov bot commented Oct 27, 2018

Codecov Report

Merging #23263 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23263   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         161      161           
  Lines       51339    51339           
=======================================
  Hits        47360    47360           
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.64% <ø> (ø) ⬆️
#single 42.34% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/generic.py 96.82% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4b945a...57f566b. Read the comment docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @EdAbati, I was checking the examples in more detail, and for me doesn't make it very easy to understand what rank does. Added some comments on how I think we could make them more clear. But fix them in a way that they make sense for you, and that they would be useful for you if you wanted to learn what rank does and you didn't know already.

@datapythonista
Copy link
Member

@EdAbati do you have time to update this PR?

@jreback
Copy link
Contributor

jreback commented Dec 14, 2018

ping @datapythonista

@datapythonista
Copy link
Member

Closing as stale, @EdAbati let us know if you want to continue working on it.

@EdAbati
Copy link
Contributor Author

EdAbati commented Dec 14, 2018

Hi @datapythonista,

Extremely sorry for the delay.
I have been very busy in the last month or so.
I was planning to come back to this one next when I will be on holiday.

@EdAbati EdAbati deleted the doc_rank branch February 3, 2019 16:35
@EdAbati
Copy link
Contributor Author

EdAbati commented Feb 15, 2019

Hi @datapythonista ,

I gave it another try.
I have opened another pull request where I have made the changes requested above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants