Skip to content

CLN: remove unused mgr kwarg #23260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@@ -1691,7 +1690,7 @@ def _nanpercentile(values, q, axis, **kw):
if self.ndim == 1:
ax = Float64Index([qs])
else:
ax = mgr.axes[0]
ax = axes[0]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only place where the passed mgr is ever used. I think we can get axes out too, but am holding off on that.

@jreback jreback added the Clean label Oct 23, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 23, 2018
@jreback
Copy link
Contributor

jreback commented Oct 23, 2018

looks fine, ping on green.

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@779aeac). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #23260   +/-   ##
=========================================
  Coverage          ?   92.22%           
=========================================
  Files             ?      169           
  Lines             ?    50904           
  Branches          ?        0           
=========================================
  Hits              ?    46947           
  Misses            ?     3957           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.65% <100%> (?)
#single 42.29% <85.71%> (?)
Impacted Files Coverage Δ
pandas/core/internals/managers.py 95.73% <100%> (ø)
pandas/core/internals/blocks.py 94.08% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779aeac...63dadd1. Read the comment docs.

@TomAugspurger
Copy link
Contributor

All green.

@TomAugspurger TomAugspurger merged commit 104ccfd into pandas-dev:master Oct 23, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel jbrockmendel deleted the nomgr branch April 5, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants