-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: remove unused mgr
kwarg
#23260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: remove unused mgr
kwarg
#23260
Conversation
Hello @jbrockmendel! Thanks for submitting the PR.
|
@@ -1691,7 +1690,7 @@ def _nanpercentile(values, q, axis, **kw): | |||
if self.ndim == 1: | |||
ax = Float64Index([qs]) | |||
else: | |||
ax = mgr.axes[0] | |||
ax = axes[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only place where the passed mgr
is ever used. I think we can get axes
out too, but am holding off on that.
looks fine, ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #23260 +/- ##
=========================================
Coverage ? 92.22%
=========================================
Files ? 169
Lines ? 50904
Branches ? 0
=========================================
Hits ? 46947
Misses ? 3957
Partials ? 0
Continue to review full report at Codecov.
|
All green. |
git diff upstream/master -u -- "*.py" | flake8 --diff