Skip to content

CLN:Remove unused **kwargs from user facing methods #23249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 12, 2018
Merged

CLN:Remove unused **kwargs from user facing methods #23249

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62231b6
CLN:Remove unused **kwargs from user facing methods
kprestel Oct 20, 2018
685ca22
Fix CI build
kprestel Oct 20, 2018
23adda8
Fix CI build
kprestel Oct 20, 2018
29a54bc
More CI fixes
kprestel Oct 20, 2018
62e0dde
Add kwargs back to support error handling
kprestel Oct 28, 2018
61dcee3
Address merge comments
kprestel Nov 3, 2018
0a785d5
Revert changes to pass numeric_only
kprestel Nov 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pandas/io/pytables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1674,7 +1674,7 @@ def cvalues(self):
def __iter__(self):
return iter(self.values)

def maybe_set_size(self, min_itemsize=None, **kwargs):
def maybe_set_size(self, min_itemsize=None):
""" maybe set a string col itemsize:
min_itemsize can be an integer or a dict with this columns name
with an integer size """
Expand All @@ -1687,13 +1687,13 @@ def maybe_set_size(self, min_itemsize=None, **kwargs):
self.typ = _tables(
).StringCol(itemsize=min_itemsize, pos=self.pos)

def validate(self, handler, append, **kwargs):
def validate(self, handler, append):
self.validate_names()

def validate_names(self):
pass

def validate_and_set(self, handler, append, **kwargs):
def validate_and_set(self, handler, append):
self.set_table(handler.table)
self.validate_col()
self.validate_attr(append)
Expand Down Expand Up @@ -3772,7 +3772,7 @@ def read_coordinates(self, where=None, start=None, stop=None, **kwargs):

return Index(coords)

def read_column(self, column, where=None, start=None, stop=None, **kwargs):
def read_column(self, column, where=None, start=None, stop=None):
"""return a single column from the table, generally only indexables
are interesting
"""
Expand Down Expand Up @@ -4727,7 +4727,7 @@ class Selection(object):

"""

def __init__(self, table, where=None, start=None, stop=None, **kwargs):
def __init__(self, table, where=None, start=None, stop=None):
self.table = table
self.where = where
self.start = start
Expand Down