-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH/TST/DOC: set infer_nrows for read_fwf (GH15138) #23238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
057eb29
ENH: set infer_nrows for read_fwf (GH15138)
9a9609d
Add documentation for infer_nrows
68d83c9
Remove documentation for infer_nrows='all'
da081a8
Add test to explicitly set infer_nrows
3f69510
Move new keyword to end of positional arguments
f3e715d
Make infer_nrows optional to retain behavior
1df0493
Make infer_nrows optional when invoking object
a35abd8
Let infer_nrows default to None to keep behavior
d5de9d9
Add a whatsnew note
49d5594
Add test for infer_nrows > number of rows
6675dac
Switch places and add versionadded tag
e1500cc
Merge branch 'master' into fwf-infer-nrows
rdmontgomery de29edf
Use infer_nrows unless n is set, default to 100
c4cfd9e
Merge branch 'fwf-infer-nrows' of https://github.com/rdmontgomery/pan…
0853be7
Merge branch 'master' into fwf-infer-nrows
3325262
Merge branch 'master' into PR_TOOL_MERGE_PR_23238
jreback d8c307e
Merge branch 'master' into fwf-infer-nrows
cc1ce14
Replace internal param with infer_nrows
ecf35d6
Add keyword back to function definition
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I actually see another problem here. I co-opted
n
because it was performing the intended function ofinfer_nrows
, but that would also break previous code that relied on callingn
explicitly. I'll return the code and tack oninfer_nrows
at the end, like you pointed out.