Skip to content

TST: Fix improperly defined tests in test_interval_new.py #23217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

jschendel
Copy link
Member

@jschendel jschendel commented Oct 18, 2018

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

I've been working over the new IntervalIndex behavior specs and found some issues with the tests for the new behavior. Wanted to make the requisite changes separately so the new behavior PR is as straightforward as possible (will open a WIP PR for it at some point soonish).

Specifically fixed a few instances of the following:

  • Combined instances of two parametrize's that should instead be one pairwise parametrize (i.e. test was doing the product of all parameters instead of pairwise parameters)
  • Used the closed fixture instead of an equivalent explicit parametrize
  • Fixed a few instances of misplaced parentheses
  • expected_result --> expected
  • parametrized one test where obvious

@jschendel jschendel added Testing pandas testing functions or related to the test suite Interval Interval data type labels Oct 18, 2018
@jschendel jschendel added this to the 0.24.0 milestone Oct 18, 2018
@jschendel jschendel force-pushed the fix-test-interval-new branch from d462ac5 to a7bbb48 Compare October 18, 2018 03:45
@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #23217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23217   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         169      169           
  Lines       50954    50954           
=======================================
  Hits        46975    46975           
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 42.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1546c35...a7bbb48. Read the comment docs.

@jreback jreback merged commit e5196aa into pandas-dev:master Oct 18, 2018
@jreback
Copy link
Contributor

jreback commented Oct 18, 2018

thanks @jschendel

@jschendel jschendel deleted the fix-test-interval-new branch October 19, 2018 21:22
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interval Interval data type Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants