-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: use fused types for the rest of libjoin #23214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# @cython.wraparound(False) | ||
# @cython.boundscheck(False) | ||
@cython.wraparound(False) | ||
@cython.boundscheck(False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the git history my impression is that this may have been commented-out unintentionally. Maybe the CI will tell us otherwise.
Codecov Report
@@ Coverage Diff @@
## master #23214 +/- ##
==========================================
+ Coverage 92.19% 92.19% +<.01%
==========================================
Files 169 169
Lines 50962 50953 -9
==========================================
- Hits 46984 46976 -8
+ Misses 3978 3977 -1
Continue to review full report at Codecov.
|
lgtm. rebase and ping on green. |
Hello @jbrockmendel! Thanks for updating the PR.
|
Ping |
thanks! |
maybe declared twice?
|
I noticed that too; it isn't clear where it's coming from. I've been keeping the cython folks up to date on issues we run into, will ask about that one if it keeps coming up. |
Just wanted to report the same, those warnings got introduced recently. But you think it is a cython issue? |
git diff upstream/master -u -- "*.py" | flake8 --diff