Skip to content

REF: use fused types for the rest of libjoin #23214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2018

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

# @cython.wraparound(False)
# @cython.boundscheck(False)
@cython.wraparound(False)
@cython.boundscheck(False)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the git history my impression is that this may have been commented-out unintentionally. Maybe the CI will tell us otherwise.

@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #23214 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23214      +/-   ##
==========================================
+ Coverage   92.19%   92.19%   +<.01%     
==========================================
  Files         169      169              
  Lines       50962    50953       -9     
==========================================
- Hits        46984    46976       -8     
+ Misses       3978     3977       -1
Flag Coverage Δ
#multiple 90.61% <100%> (ø) ⬆️
#single 42.27% <33.33%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/reshape/merge.py 94.01% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5196aa...1fde739. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Oct 18, 2018
@jreback jreback added the Clean label Oct 18, 2018
@jreback
Copy link
Contributor

jreback commented Oct 18, 2018

lgtm. rebase and ping on green.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for updating the PR.

@jbrockmendel
Copy link
Member Author

Ping

@jreback jreback merged commit 453523f into pandas-dev:master Oct 18, 2018
@jreback
Copy link
Contributor

jreback commented Oct 18, 2018

thanks!

@jreback
Copy link
Contributor

jreback commented Oct 18, 2018

@jbrockmendel

maybe declared twice?

Compiling pandas/_libs/join.pyx because it changed.
[1/1] Cythonizing pandas/_libs/join.pyx
warning: __pyxutil:33:4: '___pyx_int64_t' redeclared 
warning: __pyxutil:34:4: '___pyx_uint64_t' redeclared 
warning: __pyxutil:33:4: '___pyx_int64_t' redeclared 
warning: __pyxutil:34:4: '___pyx_uint64_t' redeclared 
warning: __pyxutil:33:4: '___pyx_int64_t' redeclared 
warning: __pyxutil:34:4: '___pyx_uint64_t' redeclared 
running build_ext
building 'pandas._libs.join' extension
gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/Users/jreback/miniconda3/envs/pandas/include -arch x86_64 -I/Users/jreback/miniconda3/envs/pandas/include -arch x86_64 -Ipandas/_libs/src/klib -Ip

@jbrockmendel
Copy link
Member Author

I noticed that too; it isn't clear where it's coming from. I've been keeping the cython folks up to date on issues we run into, will ask about that one if it keeps coming up.

@jbrockmendel jbrockmendel deleted the temp7 branch October 18, 2018 17:58
@jorisvandenbossche
Copy link
Member

Just wanted to report the same, those warnings got introduced recently. But you think it is a cython issue?

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants