-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Implement small, easy bits of other PRs #23173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @jbrockmendel! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23173 +/- ##
==========================================
+ Coverage 92.19% 92.19% +<.01%
==========================================
Files 170 169 -1
Lines 50963 50957 -6
==========================================
- Hits 46984 46979 -5
+ Misses 3979 3978 -1
Continue to review full report at Codecov.
|
@jorisvandenbossche at your convenience pls take a look and see if we can exclude this from the "hold off on merging" thing. I think getting this stuff out of the way will make things easier in the other PRs. |
I don't have time now to look in detail, can only do that tomorrow evening. Although the changes are probably all more or less fine, I still would like to hold off until we agree on a way forward, unless @TomAugspurger explicitly agrees on merging this (also simply moving things out of the PeriodArray PR can give horrible rebases for that PR. So even though it can make the diff there smaller, it doesn't necessarily make it easier to move that PR forward) |
If it's counter-productive to the stated goal, then let's leave this on the back-burner. |
Several PRs are currently in limbo with ongoing discussion. This separates out relatively easy pieces.