Skip to content

Implement small, easy bits of other PRs #23173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

jbrockmendel
Copy link
Member

Several PRs are currently in limbo with ongoing discussion. This separates out relatively easy pieces.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #23173 into master will increase coverage by <.01%.
The diff coverage is 78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23173      +/-   ##
==========================================
+ Coverage   92.19%   92.19%   +<.01%     
==========================================
  Files         170      169       -1     
  Lines       50963    50957       -6     
==========================================
- Hits        46984    46979       -5     
+ Misses       3979     3978       -1
Flag Coverage Δ
#multiple 90.61% <78%> (ø) ⬆️
#single 42.29% <48%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/base.py 95.94% <ø> (ø) ⬆️
pandas/util/testing.py 86.45% <ø> (ø) ⬆️
pandas/tseries/frequencies.py 97.08% <ø> (ø) ⬆️
pandas/core/accessor.py 98.79% <ø> (ø) ⬆️
pandas/core/sparse/frame.py 94.86% <100%> (ø) ⬆️
pandas/core/arrays/datetimelike.py 94.89% <100%> (ø) ⬆️
pandas/core/indexes/datetimelike.py 98.25% <100%> (+0.02%) ⬆️
pandas/core/arrays/timedeltas.py 94.47% <100%> (+0.5%) ⬆️
pandas/core/frame.py 97.11% <100%> (ø) ⬆️
pandas/core/indexes/timedeltas.py 90.65% <100%> (-0.12%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa69d1...8d55395. Read the comment docs.

@jbrockmendel
Copy link
Member Author

@jorisvandenbossche at your convenience pls take a look and see if we can exclude this from the "hold off on merging" thing. I think getting this stuff out of the way will make things easier in the other PRs.

@jorisvandenbossche
Copy link
Member

I don't have time now to look in detail, can only do that tomorrow evening.

Although the changes are probably all more or less fine, I still would like to hold off until we agree on a way forward, unless @TomAugspurger explicitly agrees on merging this (also simply moving things out of the PeriodArray PR can give horrible rebases for that PR. So even though it can make the diff there smaller, it doesn't necessarily make it easier to move that PR forward)

@jbrockmendel
Copy link
Member Author

If it's counter-productive to the stated goal, then let's leave this on the back-burner.

@jbrockmendel jbrockmendel deleted the small branch October 17, 2018 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants