-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Validate in docstrings that numpy and pandas are not imported #23161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TomAugspurger
merged 13 commits into
pandas-dev:master
from
thoo:check_np_pd_fromExamples
Nov 4, 2018
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8655fdd
Check numpy and pandas in Examples
thoo 5c071ec
Made changes as recommended
thoo 5aff727
remove rstrip
thoo 374c9ea
remove BadExamples class
thoo 881b011
Merge remote-tracking branch 'repo_org/master' into check_np_pd_fromE…
thoo d824414
Merge remote-tracking branch 'repo_org/master' into check_np_pd_fromE…
thoo 5d785c3
Merge remote-tracking branch 'repo_org/master' into check_np_pd_fromE…
thoo 3e512ac
Change as recommended
thoo a2011b2
Change double to single quote
thoo 0243b91
a few more changes
thoo d123b5c
a few more changes
thoo ec78655
changes in return
thoo ce37c8a
Retrigger Travis CI
thoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -402,6 +402,12 @@ def examples_errors(self): | |||||
error_msgs += f.getvalue() | ||||||
return error_msgs | ||||||
|
||||||
@property | ||||||
def examples_source_code(self): | ||||||
codes = doctest.DocTestParser().get_examples(self.raw_doc) | ||||||
lines = [line.source for line in codes] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
return lines | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
|
||||||
def validate_one(func_name): | ||||||
""" | ||||||
|
@@ -531,6 +537,13 @@ def validate_one(func_name): | |||||
examples_errs = doc.examples_errors | ||||||
if examples_errs: | ||||||
errs.append('Examples do not pass tests') | ||||||
examples_source_code = ''.join(doc.examples_source_code) | ||||||
if 'import numpy' in examples_source_code: | ||||||
errs.append("numpy does not need to be imported in the examples, " | ||||||
"as it's assumed to be already imported as np") | ||||||
if 'import pandas' in examples_source_code: | ||||||
errs.append("pandas does not need to be imported in the examples, " | ||||||
"as it's assumed to be already imported as pd") | ||||||
|
||||||
return {'type': doc.type, | ||||||
'docstring': doc.clean_doc, | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.