Skip to content

Remove offset/DTI caching (disabled since 0.14 #23118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 14, 2018
Merged

Remove offset/DTI caching (disabled since 0.14 #23118

merged 6 commits into from
Oct 14, 2018

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Oct 13, 2018 •
edited
Loading

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 13, 2018 •
edited
Loading

Codecov Report

Merging #23118 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23118      +/-   ##
==========================================
+ Coverage   92.13%   92.14%   +0.01%     
==========================================
  Files         170      170              
  Lines       51078    51016      -62     
==========================================
- Hits        47061    47009      -52     
+ Misses       4017     4007      -10
Flag Coverage Δ
#multiple 90.56% <100%> (ø) ⬆️
#single 42.3% <37.5%> (+0.02%) ⬆️
Impacted Files Coverage Δ
pandas/tseries/offsets.py 97.27% <ø> (-0.01%) ⬇️
pandas/core/indexes/datetimes.py 96.49% <100%> (+0.85%) ⬆️
pandas/core/arrays/datetimes.py 97.38% <100%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f05cc8...6f5648f. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Oct 14, 2018

I agree this is nice to remove. but just to be sure, can you run an asv on date/time types and check that it is really not used anywhere.

@jreback jreback added Datetime Datetime data dtype Clean labels Oct 14, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 14, 2018
@jreback
Copy link
Contributor

jreback commented Oct 14, 2018

also add a whatsnew note (put in api breaking changes, even though it has long been disabled)

@jbrockmendel
Copy link
Member Author

also add a whatsnew note (put in api breaking changes, even though it has long been disabled)

OK. What do I say has changed?

@jreback
Copy link
Contributor

jreback commented Oct 14, 2018

just say that the attribute has been removed; it’s just a notice that a change was made (though is not actually public folks sometimes rely on this)

@jbrockmendel
Copy link
Member Author

just say that the attribute has been removed

Done. asvs showed no change.

@jreback
Copy link
Contributor

jreback commented Oct 14, 2018

lgtm merge on green

@jbrockmendel jbrockmendel merged commit a0ca4d7 into pandas-dev:master Oct 14, 2018
@jbrockmendel jbrockmendel deleted the nocache branch October 14, 2018 19:36
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@jbrockmendel @tm9k1
Remove offset/DTI caching (disabled since 0.14 (pandas-dev#23118)
8b3cedb 
* Remove offset/DTI caching (disabled since 0.14

* remove unused import

* remove cached_range tests

* fixup remove unused imports

* whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Datetime Datetime data dtype
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

DatetimeIndex._use_cached_range, _cached_range not reachable
3 participants
@jbrockmendel @pep8speaks @jreback