Skip to content

DOC: Improve the docstring of pd.Index.contains #23107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TanyaaCJain
Copy link
Contributor

This PR updates the previous PR #20211, based on reviews and docstring standards. It was worked upon with the help of @datapythonista

Kindly review, I will make all the necessary changes to it.

@pep8speaks
Copy link

Hello @Tanya-Jain! Thanks for submitting the PR.

@datapythonista
Copy link
Member

is this different from #23100? I review that, I'd probably keep the work in there. Any problem with git to open a new PR for the same changes? Let me know if you need help.

If you prefer to continue on this one, please check the review in #23100.

@TanyaaCJain
Copy link
Contributor Author

#23100 contained an additional commit for merging commits from the pandas-dev/pandas master.
To have only the commit for the file changes made in base.py, I closed #23100 and opened #23107
I believe it would be easier to edit and merge this PR #23107 over #23100

@datapythonista
Copy link
Member

Having additional commits for merging master into your branch is expected, and not a problem at all. And same for having additional commits for the improvements based on the code reviews. As far as the diff in the PR shows only your changes, all is good, the commits will be squashed into one when the PR is merged, so don't worry about that.

The other PR has the advantage that has the first review on it, but if you prefer to continue working on this one, that's also all right. Just close the one that you won't be working on, and update the other whenever you have time.

@datapythonista datapythonista added Docs Indexing Related to indexing on series/frames, not to indexes themselves labels Oct 12, 2018
@TanyaaCJain
Copy link
Contributor Author

Thanks for clarifying this out! Since I am now working on #23100 I am closing this PR and will continue updating the original one, that is, #23100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants