Skip to content

Ignoring W504 (line break after binary operator) in linting #23101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Ignoring W504 (line break after binary operator) in linting #23101

merged 1 commit into from
Oct 12, 2018

Conversation

datapythonista
Copy link
Member

Based on the discussion in #23073, flake8 is not linting for W504. pep8speak does, and future versions of flake8 are likely to do so. So, I think we need to update our settings to ignore it explicitly, so pep8speaks is consistent with the CI, and updates on flake8 do not start to generate unwanted errors.

@datapythonista datapythonista added CI Continuous Integration Code Style Code style, linting, code_checks labels Oct 12, 2018
@datapythonista datapythonista changed the title Ignoring W504 (line break after bineay operator) in linting Ignoring W504 (line break after binary operator) in linting Oct 12, 2018
@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #23101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23101   +/-   ##
=======================================
  Coverage    92.2%    92.2%           
=======================================
  Files         169      169           
  Lines       50924    50924           
=======================================
  Hits        46952    46952           
  Misses       3972     3972
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 42.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ce3d0...c791954. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Oct 12, 2018
@jreback jreback merged commit e6277be into pandas-dev:master Oct 12, 2018
@jreback
Copy link
Contributor

jreback commented Oct 12, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants