Skip to content

REF: de-duplicate datetimelike wrapping code #23099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 12, 2018

Conversation

jbrockmendel
Copy link
Member

Should be orthogonal to other outstanding datetimelike index/array PRs

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #23099 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23099      +/-   ##
==========================================
- Coverage    92.2%   92.19%   -0.01%     
==========================================
  Files         169      169              
  Lines       50924    50863      -61     
==========================================
- Hits        46952    46893      -59     
+ Misses       3972     3970       -2
Flag Coverage Δ
#multiple 90.61% <100%> (-0.01%) ⬇️
#single 42.26% <91.42%> (-0.05%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/period.py 93.26% <100%> (-0.18%) ⬇️
pandas/core/arrays/datetimelike.py 95.49% <100%> (-0.08%) ⬇️
pandas/core/indexes/datetimes.py 95.65% <100%> (-0.09%) ⬇️
pandas/core/indexes/datetimelike.py 98.23% <100%> (+0.11%) ⬆️
pandas/core/indexes/timedeltas.py 90.76% <100%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ce3d0...19e0b76. Read the comment docs.

@jreback jreback added the Clean label Oct 12, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 12, 2018
@jreback jreback merged commit 58048e7 into pandas-dev:master Oct 12, 2018
@jreback
Copy link
Contributor

jreback commented Oct 12, 2018

thanks!

@jbrockmendel jbrockmendel deleted the dlike_dedup branch October 12, 2018 15:19
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants