Skip to content

ASV: add tests for indexing engines and Uint64Engine #23090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

topper-123
Copy link
Contributor

This is an offspring from #21699 to do the the ASV tests in a contained PR.

For reference the output from running asv run -b indexing_engines is:

· Creating environments
· Discovering benchmarks
·· Uninstalling from conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
·· Installing into conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
· Running 2 total benchmarks (1 commits * 1 environments * 2 benchmarks)
[  0.00%] · For pandas commit hash b28cf5aa:
[  0.00%] ·· Building for conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[  0.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[ 50.00%] ··· Running indexing_engines.NumericEngineIndexing.time_get_loc                                                      5.13±0.2μs;...
[100.00%] ··· Running indexing_engines.ObjectEngineIndexing.time_get_loc                                                      4.24±0.08μs;...

@pep8speaks
Copy link

Hello @topper-123! Thanks for submitting the PR.

@topper-123 topper-123 force-pushed the asv_indexing_timings branch from 5340b28 to 06cb6d5 Compare October 11, 2018 17:37
@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #23090 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23090   +/-   ##
=======================================
  Coverage    92.2%    92.2%           
=======================================
  Files         169      169           
  Lines       50924    50924           
=======================================
  Hits        46952    46952           
  Misses       3972     3972
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 42.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ce3d0...06cb6d5. Read the comment docs.

@jreback jreback added the Performance Memory or execution speed performance label Oct 18, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 18, 2018
@jreback jreback merged commit 70fcced into pandas-dev:master Oct 18, 2018
@jreback
Copy link
Contributor

jreback commented Oct 18, 2018

thanks!

@topper-123 topper-123 deleted the asv_indexing_timings branch October 18, 2018 17:46
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants