-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: Override PeriodIndex.unique #23083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @jbrockmendel! Thanks for submitting the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually these merit a whatsnew entry.
Codecov Report
@@ Coverage Diff @@
## master #23083 +/- ##
==========================================
+ Coverage 92.19% 92.19% +<.01%
==========================================
Files 169 169
Lines 50911 50919 +8
==========================================
+ Hits 46939 46947 +8
Misses 3972 3972
Continue to review full report at Codecov.
|
thanks! |
In trying to simplify the mess that is the PeriodIndex constructors, I found that PeriodIndex.unique is doing an unfortunate conversion to object-dtype. This PR avoids that and gets a nice speedup.