-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPS: drop numpy < 1.12 #23062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPS: drop numpy < 1.12 #23062
Changes from all commits
22dab2d
a495db9
124d511
12b9a79
c8bfe66
b2cffb4
e9c407e
aac634d
f18880d
f81ad9f
c29b478
7ecc5f2
6e533e7
2ab7f55
7ca1753
9b85061
5b54612
708b2f6
a41ed9f
1e0c553
317e042
31dc4fa
ec93bdb
d20077a
925b555
b971bfb
93eabad
d72b547
e075eff
305f12b
752b5d7
9dc846a
e7f5bf2
169974b
5b45639
308e943
9be3d10
61763f6
ededd73
079bdaf
162458b
cdd497d
d8587a8
8e37179
d097b43
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,15 +18,8 @@ def inner(): | |
return inner | ||
|
||
|
||
_mpl_ge_1_2_1 = _mpl_version('1.2.1', operator.ge) | ||
_mpl_le_1_2_1 = _mpl_version('1.2.1', operator.le) | ||
_mpl_ge_1_3_1 = _mpl_version('1.3.1', operator.ge) | ||
_mpl_ge_1_4_0 = _mpl_version('1.4.0', operator.ge) | ||
_mpl_ge_1_4_1 = _mpl_version('1.4.1', operator.ge) | ||
_mpl_ge_1_5_0 = _mpl_version('1.5.0', operator.ge) | ||
_mpl_ge_2_0_0 = _mpl_version('2.0.0', operator.ge) | ||
_mpl_le_2_0_0 = _mpl_version('2.0.0', operator.le) | ||
_mpl_ge_2_0_1 = _mpl_version('2.0.1', operator.ge) | ||
_mpl_ge_2_1_0 = _mpl_version('2.1.0', operator.ge) | ||
_mpl_ge_2_2_0 = _mpl_version('2.2.0', operator.ge) | ||
_mpl_ge_2_2_2 = _mpl_version('2.2.2', operator.ge) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don’t add this as it’s confusing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I removed |
||
_mpl_ge_3_0_0 = _mpl_version('3.0.0', operator.ge) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,8 +35,6 @@ | |
from pandas.tseries.frequencies import FreqGroup | ||
from pandas.core.indexes.period import Period, PeriodIndex | ||
|
||
from pandas.plotting._compat import _mpl_le_2_0_0 | ||
|
||
# constants | ||
HOURS_PER_DAY = 24. | ||
MIN_PER_HOUR = 60. | ||
|
@@ -371,13 +369,6 @@ def __init__(self, locator, tz=None, defaultfmt='%Y-%m-%d'): | |
if self._tz is dates.UTC: | ||
self._tz._utcoffset = self._tz.utcoffset(None) | ||
|
||
# For mpl > 2.0 the format strings are controlled via rcparams | ||
# so do not mess with them. For mpl < 2.0 change the second | ||
# break point and add a musec break point | ||
if _mpl_le_2_0_0(): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since mpl has a min version of 2.0.0 don't we still need this check? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That was probably being used incorrectly. I don't think it would apply to 2.0.0 but not 2.0.1. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I made sure to test all available matplotlib versions, and while the removal of the code for 2.0.0 was an oversight, nothing in the test suite failed. As far as I can tell, 2.0.0 wasn't tested in the CI before, which is also the reason that several if-switches before this PR were strictly speaking wrong (when I removed the compat code in a way that just removed pre-2.0 branches, suddenly there were failures). |
||
self.scaled[1. / SEC_PER_DAY] = '%H:%M:%S' | ||
self.scaled[1. / MUSEC_PER_DAY] = '%H:%M:%S.%f' | ||
|
||
|
||
class PandasAutoDateLocator(dates.AutoDateLocator): | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you remove code related this this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where code related to this would be hiding? There was nothing in
compat.__init__
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.