CLN GH22985 Fixed interpolation with object error message #23044
Conversation
|
Hello @pambot! Thanks for updating the PR.
Comment last updated on October 08, 2018 at 19:04 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #23044 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 169 169
Lines 50904 50904
=======================================
Hits 46933 46933
Misses 3971 3971
Continue to review full report at Codecov.
|
pandas/core/generic.py
Outdated
| @@ -6387,7 +6387,8 @@ def interpolate(self, method='linear', axis=0, limit=None, inplace=False, | |||
|
|
|||
| if _maybe_transposed_self._data.get_dtype_counts().get( | |||
| 'object') == len(_maybe_transposed_self.T): | |||
| raise TypeError("Cannot interpolate with all NaNs.") | |||
| raise TypeError("Cannot interpolate with all objects. Try setting" | |||
| "the index dtype to a numeric one.") | |||
There was a problem hiding this comment.
I may be wrong, but I don't think it's the index dtype that matters here. I think it's the dtypes of the dataframe. So maybe something like
Cannot interpolate with all object-dtype columns.
There was a problem hiding this comment.
No, you're probably right - I was inferring based on the other error messages
pambot
force-pushed
the
interpolate-object-error-msg
branch
from
92139d6 to
9af119e
Compare
jschendel
added
Missing-data
pambot
force-pushed
the
interpolate-object-error-msg
branch
2 times, most recently
from
cffc591 to
cf260da
Compare
|
@jschendel Added the test, please take a look |
| @@ -814,6 +814,18 @@ def test_interp_raise_on_only_mixed(self): | |||
| with pytest.raises(TypeError): | |||
| df.interpolate(axis=1) | |||
|
|
|||
| def test_interp_raise_on_all_object_dtype(self): | |||
| df = DataFrame({ | |||
There was a problem hiding this comment.
Can you add the GitHub issue number as a comment? See two tests below for an example. It's useful if someone makes changes that cause this test to break, as it allows them to quickly find the discussion and context for the test.
pambot
force-pushed
the
interpolate-object-error-msg
branch
from
cf260da to
fe13f5b
Compare
|
thanks @pambot |
git diff upstream/master -u -- "*.py" | flake8 --diffIt looks like the problem with #22985 is mostly the mismatch between the input trigger and the error message, so this is just a tiny hotfix.