Skip to content

DOC:Updated as suggested in the comments of PR#20211 #23039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ksasi
Copy link

@ksasi ksasi commented Oct 8, 2018

The following is added for the doc string :
"""
Return a boolean if this key is in the index.

     Parameters
     ----------
     key : object
     key to be searched.

     Returns
     -------
     boolean
     result of the search.

     See Also
     --------
     Index.isin

     Examples
     --------
     >>> pd.CategoricalIndex([2000, 2001, 2012]).contains(2001)
     True
     >>> pd.CategoricalIndex([2000, 2001, 2012]).contains(2222)
     False
     """

The suggestions mentioned in the pull request#20211 were followed. Probably this can help close pull request#20211.

@pep8speaks
Copy link

pep8speaks commented Oct 8, 2018

Hello @ksasi! Thanks for updating the PR.

Comment last updated on October 08, 2018 at 09:04 Hours UTC

@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #23039 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23039   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         169      169           
  Lines       50873    50873           
=======================================
  Hits        46904    46904           
  Misses       3969     3969
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 42.32% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce1f81f...51f8539. Read the comment docs.

@datapythonista
Copy link
Member

Sorry about it @ksasi, but @Tanya-Jain has been working with me in the final changes for this PR during the sprint, and she's got very good work that she will be submitting soon. I know it's frustraiting to have to discard work, but we need to be more careful on avoiding overlap. Try checking the last comments of the issue (or PR) and make sure nobody said is already working on it.

Hope to see you tomorrow in the sprint, and let's see if we can coordinate better then. :)

@ksasi
Copy link
Author

ksasi commented Oct 10, 2018

sure, np @datapythonista .Thanks for letting me know, I will try to work on any other open/pending items that might help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants