Skip to content

TST: collect logical ops tests, use fixtures #23029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2018

Conversation

jbrockmendel
Copy link
Member

Collect tests for logical ops |, &, ^.

Use fixtures in a couple of places in tests/arithmetic

Rename a couple of poorly named tests

No logic is changed, nothing is moved cross-module.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@jbrockmendel jbrockmendel changed the title collect logical ops tests, use fixtures TST: collect logical ops tests, use fixtures Oct 7, 2018
@codecov
Copy link

codecov bot commented Oct 7, 2018

Codecov Report

Merging #23029 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23029   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         169      169           
  Lines       50835    50835           
=======================================
  Hits        46868    46868           
  Misses       3967     3967
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 42.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5551bcf...97cacc2. Read the comment docs.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 7, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 7, 2018
@jreback jreback merged commit 25d7bd2 into pandas-dev:master Oct 7, 2018
@jreback
Copy link
Contributor

jreback commented Oct 7, 2018

thanks!

@jbrockmendel jbrockmendel deleted the failing branch October 7, 2018 22:26
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants