Skip to content

fixes the issue #22953 #23005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fixes the issue #22953 #23005

wants to merge 1 commit into from

Conversation

vvyomjjain
Copy link
Contributor

@vvyomjjain vvyomjjain commented Oct 5, 2018 •
edited
Loading

@pep8speaks
Copy link

Hello @vvyomjjain! Thanks for submitting the PR.

@vvyomjjain
Copy link
Contributor Author

@pep8speaks This is for the issue that while combining two series, it returned nan even when you had a fill_value argument. That was the issue I guess.
P.S. I am pretty new to this, I don't understand what PEP8 issue means. Thanks

@jreback
Copy link
Contributor

jreback commented Oct 5, 2018

can you fix the PR title to match the issue

@mroeschke
Copy link
Member

There is already an existing PR #22971 working on this issue. Additionally, this is an issue to add documentation and not change any code.

Feel free to work on any additional issues in the meantime or this issue if PR #22971 stalls.

@mroeschke mroeschke closed this Oct 5, 2018
@vvyomjjain
Copy link
Contributor Author

@mroeschke thank you for the clarification. I'll have a look at PR #22971.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOC: fill_value argument in Series.combine()
4 participants
@vvyomjjain @pep8speaks @jreback @mroeschke