CI: Fix yaml/yml inconsistency #23001
Conversation
| @@ -13,7 +13,7 @@ conda list | |||
| @rem Clean up any left-over from a previous build | |||
| conda remove --all -q -y -n %CONDA_ENV% | |||
| @rem Scipy, CFFI, jinja2 and IPython are optional dependencies, but exercised in the test suite | |||
| conda env create -n %CONDA_ENV% --file=ci\azure-windows-%CONDA_PY%.yaml | |||
| conda env create -n %CONDA_ENV% --file=ci\azure-windows-%CONDA_PY%.yml | |||
There was a problem hiding this comment.
why are you changing this? all of the other files are .yaml
There was a problem hiding this comment.
would rather change the existing .yml -> .yaml
There was a problem hiding this comment.
all of the other files are .yaml
The top-level config files are .yml (e.g. .travis.yml)
would rather change the existing .yml -> .yaml
Sure, will update.
Codecov Report
@@ Coverage Diff @@
## master #23001 +/- ##
==========================================
+ Coverage 92.19% 92.19% +<.01%
==========================================
Files 169 169
Lines 50831 50835 +4
==========================================
+ Hits 46864 46868 +4
Misses 3967 3967
Continue to review full report at Codecov.
|
| @@ -10,7 +10,7 @@ jobs: | |||
| maxParallel: 11 | |||
| matrix: | |||
| py35_np_110: | |||
| ENV_FILE: ci/azure-macos-35.yml | |||
There was a problem hiding this comment.
is the name of this file crucial for azure? (e.g. the .yml vs .yaml)?
There was a problem hiding this comment.
I honestly have no idea. The fact that this name can be wrong without breaking the CI is troubling.
There was a problem hiding this comment.
ok, can you rename these as well and see?
There was a problem hiding this comment.
I must have miscommunicated. The answer to the previous question is "apparently not". In the status quo, the azure/windows-py27.yml and azure/windows.yml files have ENV_FILE: ci/azure-windows-27.yml that point to non-existent files, and azure doesn't appear to notice.
There was a problem hiding this comment.
ahh interesting. so any idea how this was working? or is it just picking up the wrong env?
|
@TomAugspurger looks like you're the local expert on this. Any ideas? |
|
I guess azure is being clever and trying both? Regardless, standardizing on one seems good and |
* CI: Fix yaml/yml inconsistency
The ci/windows.yml and ci/windows-py27.yml files reference the environment files with ".yml". This PR moves the ".yaml" files to the indicated location.
CI config is hard.