-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Concat multiple different ExtensionArray types #22997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
ed56aa3
463c0bd
2a1660c
48d7137
869e2bf
b6ccab4
9507a0c
5502bb8
e17d397
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -560,11 +560,6 @@ def _concat_sparse(to_concat, axis=0, typs=None): | |
|
||
fill_values = [x.fill_value for x in to_concat | ||
if isinstance(x, SparseArray)] | ||
|
||
if len(set(fill_values)) > 1: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this was leftover from an early implementation that didn't handle multiple fill values. And I think @jorisvandenbossche noticed this in his review, but I misunderstood. Regardless, we do allow concating Series[sparse] for different fill_values, we just change them all to have the first one's fill value (in |
||
raise ValueError("Cannot concatenate SparseArrays with different " | ||
"fill values") | ||
|
||
fill_value = fill_values[0] | ||
|
||
# TODO: Fix join unit generation so we aren't passed this. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double back ticks