Skip to content

Merge asof float fix #22982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2018
Merged

Conversation

svenharris
Copy link
Contributor

Fix bug with merge_asof when merging on floats and selecting a tolerance

@pep8speaks
Copy link

Hello @svenharris! Thanks for submitting the PR.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ex comments

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #22982 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22982      +/-   ##
==========================================
- Coverage   92.18%   92.18%   -0.01%     
==========================================
  Files         169      169              
  Lines       50823    50828       +5     
==========================================
+ Hits        46853    46856       +3     
- Misses       3970     3972       +2
Flag Coverage Δ
#multiple 90.6% <50%> (-0.01%) ⬇️
#single 42.36% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/merge.py 93.89% <50%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c282e31...928faaa. Read the comment docs.

@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Dtype Conversions Unexpected or buggy dtype conversions labels Oct 4, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 4, 2018
@jreback
Copy link
Contributor

jreback commented Oct 4, 2018

lgtm. @mroeschke merge when satisfied

@mroeschke mroeschke merged commit 4976ee1 into pandas-dev:master Oct 4, 2018
@mroeschke
Copy link
Member

Thanks @svenharris

@svenharris svenharris deleted the merge_asof_float_fix branch October 17, 2018 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge_asof doesn't allow float tolerance for float merges
4 participants