-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Merge asof float fix #22982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge asof float fix #22982
Conversation
Hello @svenharris! Thanks for submitting the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ex comments
Codecov Report
@@ Coverage Diff @@
## master #22982 +/- ##
==========================================
- Coverage 92.18% 92.18% -0.01%
==========================================
Files 169 169
Lines 50823 50828 +5
==========================================
+ Hits 46853 46856 +3
- Misses 3970 3972 +2
Continue to review full report at Codecov.
|
…rge_asof_float_fix
lgtm. @mroeschke merge when satisfied |
Thanks @svenharris |
Fix bug with merge_asof when merging on floats and selecting a tolerance
git diff upstream/master -u -- "*.py" | flake8 --diff