-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Analytics.py fixtures added #22940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics.py fixtures added #22940
Conversation
akulagrawal
commented
Oct 2, 2018
- Analytics.py tests passed
- Analytics.py fixtures added for issue TST/CLN: remove TestData from frame-tests; replace with fixtures #22471
Hello @akulagrawal! Thanks for updating the PR.
Comment last updated on October 02, 2018 at 04:59 Hours UTC |
Oh yes. Corrected! |
There's some issue with conftest.py which wasn't earlier. |
@akulagrawal BTW, the reason this doesn't work is that there are class methods |
@@ -788,12 +788,13 @@ def alt(x): | |||
assert kurt.name is None | |||
assert kurt2.name == 'bar' | |||
|
|||
def _check_stat_op(self, name, alternative, frame=None, has_skipna=True, | |||
def _check_stat_op(self, name, alternative, float_frame, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with the test failures is that this isn't a test case, so parametrization does not pass in float_frame
and float_string_frame
as arguments automatically. You'll need to explicitly pass in to this method