Skip to content

Analytics.py fixtures added #22940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Analytics.py fixtures added #22940

wants to merge 2 commits into from

Conversation

akulagrawal
Copy link

@pep8speaks
Copy link

pep8speaks commented Oct 2, 2018

Hello @akulagrawal! Thanks for updating the PR.

Line 792:1: E101 indentation contains mixed spaces and tabs
Line 792:1: W191 indentation contains tabs
Line 792:10: E128 continuation line under-indented for visual indent
Line 1329:61: W291 trailing whitespace
Line 1330:1: E101 indentation contains mixed spaces and tabs
Line 1330:1: W191 indentation contains tabs
Line 1330:10: E128 continuation line under-indented for visual indent
Line 1845:1: E101 indentation contains mixed spaces and tabs
Line 1845:1: W191 indentation contains tabs
Line 1845:9: E128 continuation line under-indented for visual indent

Comment last updated on October 02, 2018 at 04:59 Hours UTC

@akulagrawal
Copy link
Author

akulagrawal commented Oct 2, 2018

Oh yes. Corrected!

@akulagrawal
Copy link
Author

There's some issue with conftest.py which wasn't earlier.

@h-vetinari
Copy link
Contributor

h-vetinari commented Oct 2, 2018

@akulagrawal
There's an open PR for the test_analytics.py module at #22733 - I've referenced PRs where they exist in #22471, please check before-hand. In this case, I would recommend closing this PR and focussing on other modules.

BTW, the reason this doesn't work is that there are class methods _check_stat_op and _check_bool_op which make fixturization harder. Again, I would recommend to test locally before you push, and get rid of all errors.

@jschendel jschendel added Testing pandas testing functions or related to the test suite Clean labels Oct 2, 2018
@@ -788,12 +788,13 @@ def alt(x):
assert kurt.name is None
assert kurt2.name == 'bar'

def _check_stat_op(self, name, alternative, frame=None, has_skipna=True,
def _check_stat_op(self, name, alternative, float_frame,
Copy link
Member

@WillAyd WillAyd Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with the test failures is that this isn't a test case, so parametrization does not pass in float_frame and float_string_frame as arguments automatically. You'll need to explicitly pass in to this method

@akulagrawal akulagrawal closed this Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants