Solved issue #22471 Replaced TestData with fixtures

[akulagrawal]

• close TST/CLN: remove TestData from frame-tests; replace with fixtures #22471
• tests updated
• removed TestData from frame-tests, replace with fixtures

[h-vetinari]

@akulagrawal

Was too slow to answer in the issue, but here are a few points:

• Keep it to one module (=file) per pull request (=PR)

• I wrote in TST/CLN: remove TestData from frame-tests; replace with fixtures #22471:

  Basically, it comes down to replacing all the occurrences of self.<name> with translation_guide[<name>] (and specifying <name> as a parameter to the function).

  You did not do this here, and so the tests cannot possibly pass.

• To test locally:

  • (make sure you're in the right environment and folder)
  • run pytest pandas/tests/frame/test_xxx.py from the command line and fix any failures

• Do the same with flake8 pandas/tests/frame/test_xxx.py to make sure your PR will not fail the lint checks

General points:

• Good idea to read and follow https://pandas.pydata.org/pandas-docs/stable/contributing.html
• In particular, create branches off your local master branch for each separate PR.

[akulagrawal]

@h-vetinari. Thanks for the help! my bad I didn't specify as a parameter to the function!

[jreback]

let's do this in smaller batches. If its a long / complicated file, then a single file per PR is ok, if its mostly trivial changes then you can group multiple files into a single PR.