Use fused types for _take_2d #22917
Merged
Use fused types for _take_2d #22917
+81
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22917 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 169 169
Lines 50831 50831
=======================================
Hits 46864 46864
Misses 3967 3967
Continue to review full report at Codecov.
|
jreback
requested changes
Oct 1, 2018
|
|
||
| if take_t is object: | ||
| # evaluated at compile-time | ||
| result = values.copy() |
There was a problem hiding this comment.
This is just maintaining the status quo, so I didn't try it the other way.
|
rebase. I assume you want to merge this, or was this just testing things? |
Done and yes |
jreback
approved these changes
Oct 5, 2018
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc cleanup
For some of the cython code I get unexplained test failures when using fused types. Vaguely hoping to narrow down the set of affected functions so as to make a helpful bug report to cython.