CLN GH22875 Replace bare excepts by explicit excepts in pandas/io/

[JustinZhengBC]

• closes Replace bare excepts by explicit excepts in pandas/io/ #22875
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

I removed the except block in pandas/io/pickle.py:172:13 because the only difference between the try block and the except block was one parameter in the call to pc.load, and the parameter that was changing didn't look like it was being used by pc.load.

Original block:

try:
    return read_wrapper(
        lambda f: pc.load(f, encoding=encoding, compat=False))
# compat pickle
except:
    return read_wrapper(
        lambda f: pc.load(f, encoding=encoding, compat=True))

The function it was calling (in pandas/compat/pickle_compat.py):

def load(fh, encoding=None, compat=False, is_verbose=False):
    """load a pickle, with a provided encoding

    if compat is True:
       fake the old class hierarchy
       if it works, then return the new type objects

    Parameters
    ----------
    fh: a filelike object
    encoding: an optional encoding
    compat: provide Series compatibility mode, boolean, default False
    is_verbose: show exception output
    """

    try:
        fh.seek(0)
        if encoding is not None:
            up = Unpickler(fh, encoding=encoding)
        else:
            up = Unpickler(fh)
        up.is_verbose = is_verbose

        return up.load()
    except:
        raise

[pep8speaks]

Hello @JustinZhengBC! Thanks for submitting the PR.

• There are no PEP8 issues in the file pandas/io/clipboards.py !

• There are no PEP8 issues in the file pandas/io/formats/console.py !

• There are no PEP8 issues in the file pandas/io/formats/terminal.py !

• There are no PEP8 issues in the file pandas/io/packers.py !

• There are no PEP8 issues in the file pandas/io/parsers.py !

• There are no PEP8 issues in the file pandas/io/pickle.py !

• There are no PEP8 issues in the file pandas/io/sas/sas_xport.py !

• There are no PEP8 issues in the file pandas/io/sas/sasreader.py !

• There are no PEP8 issues in the file pandas/io/sql.py !

• There are no PEP8 issues in the file pandas/io/stata.py !

[codecov]

Codecov Report

Merging #22916 into master will not change coverage.
The diff coverage is 31.57%.

@@           Coverage Diff           @@
##           master   #22916   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         169      169           
  Lines       50830    50830           
=======================================
  Hits        46860    46860           
  Misses       3970     3970

Flag	Coverage Δ
#multiple	90.6% <31.57%> (ø)	⬆️
#single	42.37% <5.26%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/io/clipboards.py	100% <ø> (ø)	⬆️
pandas/io/formats/terminal.py	21.25% <0%> (ø)	⬆️
pandas/io/packers.py	88.04% <0%> (ø)	⬆️
pandas/io/sas/sas_xport.py	90.23% <0%> (ø)	⬆️
pandas/io/sas/sasreader.py	86.2% <0%> (ø)	⬆️
pandas/io/parsers.py	95.6% <50%> (ø)	⬆️
pandas/io/formats/console.py	75.75% <75%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1b842...90cfe17. Read the comment docs.

[datapythonista]

lgtm, if you can just delete those unnecessary comments

@jreback ?

Thanks @JustinZhengBC

[datapythonista]

the noqa shouldn't be necessary anymore

[datapythonista]

the noqa shouldn't be necessary anymore

[datapythonista]

@JustinZhengBC any reason to close this PR? I think it was ready to be merged.

[JustinZhengBC]

I was trying to get Travis to rebuild by closing and reopening but it turns out that doesn’t work if I previously deleted my fork (which I did after accidentally pushing to master). I have resubmitted it as referenced above.