Skip to content

Remove bare exceptions from 'pandas/tests' to decrease flake8 E722 warnings #22882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/tests/indexing/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def get_result(self, obj, method, key, axis):
with catch_warnings(record=True):
try:
xp = getattr(obj, method).__getitem__(_axify(obj, key, axis))
except:
except AttributeError:
xp = getattr(obj, method).__getitem__(key)

return xp
Expand Down Expand Up @@ -214,7 +214,7 @@ def _print(result, error=None):

try:
xp = self.get_result(obj, method2, k2, a)
except:
except Exception:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you be more specific here

result = 'no comp'
_print(result)
return
Expand Down
4 changes: 2 additions & 2 deletions pandas/tests/io/formats/test_format.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def has_horizontally_truncated_repr(df):
try: # Check header row
fst_line = np.array(repr(df).splitlines()[0].split())
cand_col = np.where(fst_line == '...')[0][0]
except:
except IndexError:
return False
# Make sure each row has this ... in the same place
r = repr(df)
Expand Down Expand Up @@ -452,7 +452,7 @@ def test_to_string_repr_unicode(self):
for line in rs[1:]:
try:
line = line.decode(get_option("display.encoding"))
except:
except Exception:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

pass
if not line.startswith('dtype:'):
assert len(line) == line_len
Expand Down
8 changes: 4 additions & 4 deletions pandas/tests/io/test_pytables.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@ def safe_remove(path):
if path is not None:
try:
os.remove(path)
except:
except OSError:
pass


def safe_close(store):
try:
if store is not None:
store.close()
except:
except Exception:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

pass


Expand Down Expand Up @@ -117,7 +117,7 @@ def _maybe_remove(store, key):
no content from previous tests using the same table name."""
try:
store.remove(key)
except:
except Exception:
pass


Expand Down Expand Up @@ -4621,7 +4621,7 @@ def do_copy(f, new_f=None, keys=None,
safe_close(tstore)
try:
os.close(fd)
except:
except ValueError:
pass
safe_remove(new_f)

Expand Down
10 changes: 7 additions & 3 deletions pandas/tests/io/test_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -1787,10 +1787,12 @@ def test_read_procedure(self):

connection = self.conn.connect()
trans = connection.begin()

from pymysql.err import Error
try:
r1 = connection.execute(proc) # noqa
trans.commit()
except:
except Error:
trans.rollback()
raise

Expand Down Expand Up @@ -2370,12 +2372,13 @@ def setup_class(cls):

# test connection
import pymysql
from pymysql.err import Error
try:
# Try Travis defaults.
# No real user should allow root access with a blank password.
pymysql.connect(host='localhost', user='root', passwd='',
db='pandas_nosetest')
except:
except Error:
pass
else:
return
Expand All @@ -2397,12 +2400,13 @@ def setup_class(cls):
def setup_method(self, request, datapath):
_skip_if_no_pymysql()
import pymysql
from pymysql.err import Error
try:
# Try Travis defaults.
# No real user should allow root access with a blank password.
self.conn = pymysql.connect(host='localhost', user='root',
passwd='', db='pandas_nosetest')
except:
except Error:
pass
else:
return
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/test_multilevel.py
Original file line number Diff line number Diff line change
Expand Up @@ -1375,7 +1375,7 @@ def f():

try:
df = f()
except:
except Exception:
pass
assert (df['foo', 'one'] == 0).all()

Expand Down
8 changes: 4 additions & 4 deletions pandas/tests/test_nanops.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,12 @@ def _coerce_tds(targ, res):
if axis != 0 and hasattr(
targ, 'shape') and targ.ndim and targ.shape != res.shape:
res = np.split(res, [targ.shape[0]], axis=0)[0]
except:
except (ValueError, IndexError):
targ, res = _coerce_tds(targ, res)

try:
tm.assert_almost_equal(targ, res, check_dtype=check_dtype)
except:
except AssertionError:

# handle timedelta dtypes
if hasattr(targ, 'dtype') and targ.dtype == 'm8[ns]':
Expand All @@ -167,11 +167,11 @@ def _coerce_tds(targ, res):
else:
try:
res = res.astype('c16')
except:
except Exception:
res = res.astype('f8')
try:
targ = targ.astype('c16')
except:
except Exception:
targ = targ.astype('f8')
# there should never be a case where numpy returns an object
# but nanops doesn't, so make that an exception
Expand Down
4 changes: 2 additions & 2 deletions pandas/tests/test_panel.py
Original file line number Diff line number Diff line change
Expand Up @@ -335,13 +335,13 @@ def check_op(op, name):
for op in ops:
try:
check_op(getattr(operator, op), op)
except:
except (AttributeError, KeyError):
pprint_thing("Failing operation: %r" % op)
raise
if compat.PY3:
try:
check_op(operator.truediv, 'div')
except:
except (AttributeError, KeyError):
pprint_thing("Failing operation: %r" % 'div')
raise

Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/test_strings.py
Original file line number Diff line number Diff line change
Expand Up @@ -2660,7 +2660,7 @@ def test_slice(self):
expected = Series([s[start:stop:step] if not isna(s) else NA
for s in values])
tm.assert_series_equal(result, expected)
except:
except IndexError:
print('failed on %s:%s:%s' % (start, stop, step))
raise

Expand Down