Skip to content

ERR: Clarify location of EOF on unbalanced quotes #22814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Sep 24, 2018

  • Clarifies message in the C engine (original issue)
  • Python's csv module no longer fires specific errors for that, so removed it from handling

Closes #22789.

@gfyoung gfyoung added Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv labels Sep 24, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Sep 24, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #22814 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22814      +/-   ##
==========================================
+ Coverage   92.18%   92.18%   +<.01%     
==========================================
  Files         169      169              
  Lines       50820    50818       -2     
==========================================
- Hits        46850    46849       -1     
+ Misses       3970     3969       -1
Flag Coverage Δ
#multiple 90.6% <ø> (ø) ⬆️
#single 42.38% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.6% <ø> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab57b2...80b1c97. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Sep 25, 2018

ok this all looks good. worth a what's note?

@gfyoung
Copy link
Member Author

gfyoung commented Sep 25, 2018

ok this all looks good. worth a what's note?

I was on the fence for that one. It's so small that it didn't seem to merit it...up to you. 🙂

@jreback jreback merged commit 6b1f460 into pandas-dev:master Sep 25, 2018
@jreback
Copy link
Contributor

jreback commented Sep 25, 2018

nope looks good. thanks

@gfyoung gfyoung deleted the eof-inside-str-msg branch September 28, 2018 08:01
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants