DOC: Fix outdated default values in util.testing docstrings #22776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @dargueta! Thanks for submitting the PR.
|
dargueta
commented
Sep 19, 2018
| @@ -1326,12 +1326,13 @@ def assert_frame_equal(left, right, check_dtype=True, | |||
| Second DataFrame to compare. | |||
| check_dtype : bool, default True | |||
| Whether to check the DataFrame dtype is identical. | |||
| check_index_type : {'equiv'} or bool, default 'equiv' | |||
| check_index_type : bool / string {'equiv'}, default 'equiv' | |||
There was a problem hiding this comment.
I think this and everything below it in this diff is from a botched rebase. Trying to fix it...
Codecov Report
@@ Coverage Diff @@
## master #22776 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 169 169
Lines 50778 50778
=======================================
Hits 46807 46807
Misses 3971 3971
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
Sep 20, 2018
jorisvandenbossche
changed the title
|
@dargueta Thanks ! |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff