Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC: fix DataFrame.isin docstring and doctests #22767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: fix DataFrame.isin docstring and doctests #22767
Changes from 3 commits
0d3ebaa
3684653
82530fa
b5af788
a781439
e59e69f
938a21f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boolean -> booleans
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a
See Also
section? I thinkDataFrame.eq
andSeries.str.isin
are worth referencing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about using
df.isin([0, 2])
? I like the example, but I don't like showing just the case with one value invalues
, as it'd be better in that case to simply dodf == 2
.Also, I think adding a bit more description would help (e.g.
When values is a list, check whether every value in the DataFrame is present in the list (which animals have 0 or 2 legs or wings)
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add something to this sentence to explain what is happening when values is a dict. Something like "When values is a dict, we can pass values to check for each column separately:"
(similar for the example below as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the example, but I don't like that we have to use wrong information (a falcon without legs) ;)
Not sure if better of worse, but what do you think about using a DataFrame with just the
num_wings
column instead? And may be we can get rid of the parrot, and showdf2
content, so it's clearer to see what's going on?Also, small detail, but I think we used
other
instead ofdf2
in other docstrings.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see :). No problem I agree with the changes!