BUG: fix numpy deprecation warning for scalar datetime64 values #22742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @fjetter! Thanks for submitting the PR.
|
|
i think this is covered by #22699 already |
|
#22699 is silencing it for now. https://github.com/pandas-dev/pandas/pull/22699/files#diff-3bbe4551f20de6060dce38a95d0adc80R961 is the relevant line. |
|
As far as testing goes, I don't think we need a new test, as this would have failed if #22699 were in already. I don't think this needs to go in 0.23.5. |
jreback
reviewed
Sep 18, 2018
doc/source/whatsnew/v0.23.5.txt
Outdated
| @@ -26,7 +26,7 @@ Fixed Regressions | |||
| - Calling :meth:`DataFrameGroupBy.rank` and :meth:`SeriesGroupBy.rank` with empty groups | |||
| and ``pct=True`` was raising a ``ZeroDivisionError`` due to `c1068d9 | |||
| <https://github.com/pandas-dev/pandas/commit/c1068d9d242c22cb2199156f6fb82eb5759178ae>`_ (:issue:`22519`) | |||
| - | |||
| - Constructing a Series with a numpy.datetime64 value will no longer issue a DeprecationWarning (:issue:`22741`) | |||
There was a problem hiding this comment.
yeah pls move this to 0.24.0
fjetter
force-pushed
the
bugfix/issue22741/numpy_deprecation_warning
branch
from
dece94e to
331f4f9
Compare
gfyoung
reviewed
Sep 21, 2018
| @@ -803,6 +803,7 @@ Other | |||
| - Require at least 0.28.2 version of ``cython`` to support read-only memoryviews (:issue:`21688`) | |||
| - :meth:`~pandas.io.formats.style.Styler.background_gradient` now also supports tablewise application (in addition to rowwise and columnwise) with ``axis=None`` (:issue:`15204`) | |||
| - :meth:`~pandas.io.formats.style.Styler.bar` now also supports tablewise application (in addition to rowwise and columnwise) with ``axis=None`` and setting clipping range with ``vmin`` and ``vmax``. ``NaN`` values are also handled properly. (:issue:`21548`, :issue:`21526`) | |||
| - Constructing a Series with a numpy.datetime64 value will no longer issue a DeprecationWarning (:issue:`22741`) | |||
There was a problem hiding this comment.
Double backticks on Series, numpy.datetime64, and DeprecationWarning.
gfyoung
added
Deprecate
| @@ -1042,7 +1042,7 @@ def maybe_cast_to_datetime(value, dtype, errors='raise'): | |||
| "dtype [{dtype}]".format(dtype=dtype)) | |||
|
|
|||
| if is_scalar(value): | |||
| if value == iNaT or isna(value): | |||
| if np.asscalar(value) == iNaT or isna(value): | |||
There was a problem hiding this comment.
Shouldn’t value already be a scalar at this point?
|
closing as stale. if you'd like to continue, pls ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the DeprecationWarning described in #22741 . Not sure if it's worth adding a test. What's the policy on things like these?
git diff upstream/master -u -- "*.py" | flake8 --diff