TST: Test for bug fixed during #22534 discussion #22694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jbrockmendel! Thanks for submitting the PR.
|
gfyoung
added
Testing
gfyoung
reviewed
Sep 14, 2018
|
|
||
| result = df.add(tser, axis=0) | ||
| expected = pd.DataFrame({0: dti + tdi, | ||
| 1: tdi + tdi}) |
There was a problem hiding this comment.
I generally prefer that the expected be as explicit as possible i.e., write out the actual result of those "sums" instead of the expression. You can add a comment if needed to describe that we expected dti + tdi and tdi + tdi.
There was a problem hiding this comment.
I agree with you generally, but these types of tests its ok.
aeltanawy
pushed a commit
to aeltanawy/pandas
that referenced
this pull request
Sep 20, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of profiling #22534 a bug was found, but that PR was made redundant and the bug fixed in master. This just adds a test for that bug.