BUG/ENH: Handle AmbiguousTimeError in date rounding #22647
Conversation
|
Hello @mroeschke! Thanks for updating the PR.
Comment last updated on September 19, 2018 at 20:20 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #22647 +/- ##
==========================================
+ Coverage 92.17% 92.17% +<.01%
==========================================
Files 169 169
Lines 50769 50772 +3
==========================================
+ Hits 46798 46801 +3
Misses 3971 3971
Continue to review full report at Codecov.
|
| ambiguous : bool, 'NaT', default 'raise' | ||
| - bool contains flags to determine if time is dst or not (note | ||
| that this flag is only applicable for ambiguous fall dst dates) | ||
| - 'NaT' will return NaT for an ambiguous time |
There was a problem hiding this comment.
can you add versionadded tags here (and other new arg places)
| that this flag is only applicable for ambiguous fall dst dates) | ||
| - 'NaT' will return NaT for an ambiguous time | ||
| - 'raise' will raise an AmbiguousTimeError for an ambiguous time | ||
|
|
There was a problem hiding this comment.
may make sense to provide a template for the doc-strings (can be followup)
| - 'infer' will attempt to infer fall dst-transition hours based on | ||
| order | ||
| - bool-ndarray where True signifies a DST time, False designates | ||
| a non-DST time (note that this flag is only applicable for |
There was a problem hiding this comment.
versionadded
can you test for .dt accessors as well?
There was a problem hiding this comment.
The .dt accessor tests are here:
|
Addressed your comments and all green @jreback |
|
thanks @mroeschke |
git diff upstream/master -u -- "*.py" | flake8 --diffDiscussed in #22560, adding an
ambiguousargument toround,ceilandfloorso the user can dictate how to handle rounding timestamps that land on ambiguous times.