TST: Collect/Use arithmetic test fixtures #22645
Conversation
|
Hello @jbrockmendel! Thanks for updating the PR.
Comment last updated on September 10, 2018 at 01:57 Hours UTC |
setup.cfg has W503 ignored for this this warning. Why does pep8speaks think its W504? |
jbrockmendel
changed the title
|
Traditional resourceWarning in circleCI |
Codecov Report
@@ Coverage Diff @@
## master #22645 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 169 169
Lines 50708 50708
=======================================
Hits 46740 46740
Misses 3968 3968
Continue to review full report at Codecov.
|
| return request.param | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def tdser(): |
There was a problem hiding this comment.
should conform / rename these at some point (e.g. have been using: timedelta_series) for something like this
| ids=lambda x: type(x).__name__) | ||
| def idx(request): | ||
| def numeric_idx(request): |
There was a problem hiding this comment.
numeric_index (can be future PR)
| Return a Series with dtype='timedelta64[ns]', including a NaT. | ||
| """ | ||
| return pd.Series(['59 Days', '59 Days', 'NaT'], dtype='timedelta64[ns]') | ||
|
|
There was a problem hiding this comment.
these 2 fixtures should be pushed up to pandas/conftest.py as well
|
thanks. my comments are for a future PR FYI |
Takes over from #22350 (which would have been a rebasing nightmare), addressing AFAICT all unaddressed comments from there.
All remaining fixtures in tests/arithmetic are collected in tests/arithmetic/conftest.py
Fixtures are given more descriptive names and docstrings as requested in #22350.
A handful of tests are altered to use fixtures; in a number of cases their
pytest.mark.parametrizearguments were already equivalent to one of the fixtures.A few new broken cases are identified, specifically numeric
SeriesandDataFrame__mul__or__rdiv__with a) non-nanosecondtimedelta64or b)Tick. (I'll open an Issue for these)Some tests got cleaned up nicely by using
tm.assert_equalinstead of parametrizing withassert_func