Skip to content

Fix string format in test runner #22598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Conversation

rhysparry
Copy link
Contributor

.format() was expecting keyword arguments. Updated to match other skips nearby.

`.format()` was expecting keyword arguments. Updated to match other skips nearby.
@pep8speaks
Copy link

Hello @rhysparry! Thanks for submitting the PR.

file_to_check.py:2442:-258: W605 invalid escape sequence '('
file_to_check.py:2442:-255: W605 invalid escape sequence ')'


Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mind updating the PR title to something like "Fix string format in test runner" the current one is a bit misleading

@TomAugspurger
Copy link
Contributor

If you fetch and merge master the CI failures should be fixed.

* master:
  DOC: Update link and description of the Spyder IDE in Ecosystem docs (pandas-dev#22136)
  BUG: resample with TimedeltaIndex, fenceposts are off (pandas-dev#22488)
  Use dispatch_to_series where possible (pandas-dev#22572)
  BLD: Fix openpyxl to 2.5.5 (pandas-dev#22601)
@rhysparry rhysparry changed the title Fix skipping test due to lack of connectivity Fix string format in test runner Sep 5, 2018
@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Strings String extension data type and string data labels Sep 5, 2018
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #22598 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22598   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50782    50782           
=======================================
  Hits        46742    46742           
  Misses       4040     4040
Flag Coverage Δ
#multiple 90.45% <ø> (ø) ⬆️
#single 42.3% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 85.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2e1a10...7525271. Read the comment docs.

@gfyoung gfyoung merged commit 14ccdd2 into pandas-dev:master Sep 6, 2018
@gfyoung
Copy link
Member

gfyoung commented Sep 6, 2018

@rhysparry : Thanks!

aeltanawy pushed a commit to aeltanawy/pandas that referenced this pull request Sep 20, 2018
`.format()` was expecting keyword arguments. Updated to match other skips nearby.
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
`.format()` was expecting keyword arguments. Updated to match other skips nearby.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Strings String extension data type and string data Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants