TST: add test to io/formats/test_to_html.py to close GH6131 #22588
Conversation
simonjayhawkins
changed the title
gfyoung
added
Testing
|
@simonjayhawkins : Thanks for this! Could you rebase onto |
|
Hello @simonjayhawkins! Thanks for updating the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #22588 +/- ##
==========================================
+ Coverage 92.16% 92.17% +0.01%
==========================================
Files 169 169
Lines 50708 50708
==========================================
+ Hits 46734 46740 +6
+ Misses 3974 3968 -6
Continue to review full report at Codecov.
|
| {'a': 'ab', 'b': 'bb', 'c': 'cc', 'd': 2}, | ||
| {'a': 'ac', 'b': 'bc', 'c': 'cc', 'd': 3} | ||
| ]) | ||
| result = df.pivot_table( |
There was a problem hiding this comment.
Rather than creating df and then pivoting can you simplify and just create the desired frame (i.e. the result of the pivot)?
| @@ -1844,6 +1844,64 @@ def test_to_html_no_index_max_rows(self): | |||
| </table>""") | |||
| assert result == expected | |||
|
|
|||
| def test_to_html_pivot_table_max_cols(self): | |||
| # GH https://github.com/pandas-dev/pandas/issues/6131 | |||
There was a problem hiding this comment.
Minor nit but don't need full link - can just do # GH 6131
|
@WillAyd i made a couple of additional changes to your request in the latest commit which on hindsight may not have been such a good idea. i changed the name of the test since it no longer includes a pivot table command and secondly i took the opportunity of fixing a typo in the original problem description and so now the test does not faithfully recreate the original issue. will be happy to amend as necessary. |
|
thanks @simonjayhawkins |
git diff upstream/master -u -- "*.py" | flake8 --diff