-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Update ecosystem.rst to include Pint #22582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22582 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 161 161
Lines 51497 51497
=======================================
Hits 47530 47530
Misses 3967 3967
Continue to review full report at Codecov.
|
I’ll take a look at pint#684; units support have been an often-requested feature for pandas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this needs a new release of pint yes? pls indicate the minimum version here.
We know the version number from hgrecco/pint#693 (comment), can I do anything else? |
@jreback @jbrockmendel any idea why this is failing..? |
Looks like a CI bug that was cleared up a couple days ago. Try rebasing? |
501bc97
to
2b55975
Compare
can you merge master and update |
We're working on a new release of Pint (hgrecco/pint#693) but none of us can find the time right now, I hope to in January |
CI is green now, is this ready to be merged, or are we waiting for the next Pint release? |
@znicholls is this ready to be merged? or is a new Pint release or something else needed? |
Up to you guys. It will be included in the next Pint release but maybe best wait given we're still a bit uncertain about how best to do it (Panda's pytest test suite isn't playing nice with Pint's unittest test suite and we don't understand why, see hgrecco/pint#741) |
Ok, I see. Thanks for the clarification. I'll then close this PR for now, but please ping us when you update Pint, so we reopen it and discuss any needed change then. |
@datapythonista we have release pint-pandas on pypi (https://pypi.org/project/Pint-Pandas/). I've re-written the docs (see e.g. https://github.com/znicholls/pandas/blob/patch-1/doc/source/ecosystem.rst#pint-pandas) so can we re-open or make a new PR please? FYI @hgrecco and @andrewgsavage |
GitHub doesn't let me reopen this PR, since the branch has been forced pushed or recreated. Can you open a new PR please? Also, the ecosystem was moved to the website, it's a different file now. Thanks for the work on this. |
ok cool have made #35170 |
We are working on upgrading pint to be compatible with pandas, see hgrecco/pint#684
I am guessing that the line in the docs,
meant something like this pull request. If that's completely wrong, apologies.
git diff upstream/master -u -- "*.py" | flake8 --diff
*