Skip to content

CLN: Simplify read_csv tz offset parsing #22494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2018

Conversation

mroeschke
Copy link
Member

I think after #22457 we do not need the np.asarray calls that were introduced in #22380

@gfyoung gfyoung added IO CSV read_csv, to_csv Clean labels Aug 24, 2018
@gfyoung
Copy link
Member

gfyoung commented Aug 24, 2018

If tests pass, I'm +1 for this.

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #22494 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22494   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50776    50776           
=======================================
  Hits        46737    46737           
  Misses       4039     4039
Flag Coverage Δ
#multiple 90.45% <100%> (ø) ⬆️
#single 42.23% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.48% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d176d...97e0e6b. Read the comment docs.

@mroeschke
Copy link
Member Author

Looks like tests are passing besides a travis build termination.

@jreback jreback added this to the 0.24.0 milestone Aug 29, 2018
@jreback jreback merged commit bace715 into pandas-dev:master Aug 29, 2018
@jreback
Copy link
Contributor

jreback commented Aug 29, 2018

thanks!

@mroeschke mroeschke deleted the simplify_read_csv_tz_parse branch August 29, 2018 15:56
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants