Fixing _get_standard_colors to honor num_colors arguments (#20585) #22439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @atulagrwl! Thanks for updating the PR.
Comment last updated on August 21, 2018 at 10:57 Hours UTC |
pandas/tests/plotting/test_series.py
Outdated
| @@ -268,6 +269,34 @@ def test_bar_user_colors(self): | |||
| (1., 0., 0., 1.)] | |||
| assert result == expected | |||
|
|
|||
| def test_bar_user_colors_limited(self): | |||
| s = Series([1, 2, 3, 4]) | |||
There was a problem hiding this comment.
Add a reference to the original issue in a comment here.
|
@TomAugspurger - Thanks for quick review. Would really appreciate merging it to master soon (this would be my first contribution to get into master). |
jreback
requested changes
Aug 22, 2018
| @@ -1233,6 +1233,16 @@ def _plot(cls, ax, x, y, w, start=0, log=False, **kwds): | |||
| def _start_base(self): | |||
| return self.bottom | |||
|
|
|||
| def _get_colors(self, num_colors=None, color_kwds='color'): | |||
| color = self.kwds.get(color_kwds) | |||
There was a problem hiding this comment.
can you add a doc-string here
| @@ -91,7 +91,9 @@ def _maybe_valid_colors(colors): | |||
| # mpl will raise error any of them is invalid | |||
| pass | |||
|
|
|||
| if len(colors) != num_colors: | |||
There was a problem hiding this comment.
can you add a comment here
|
tests are failing as well |
|
@atulagrwl do you plan on making the changes requested of you above? I'd love to see this bugfix get merged. |
|
Closing as stale. Ping if you'd like to pick back up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff