-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
POC Use fused types more, tempita less #22432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Haven't reviewed in detail yet but high level would you still expect this code to live in the |
No, for the real version of this the affected functions would be moved out of the pxi.in files into the regular pyx files. While in progress it's easier to cut and paste within the same file. |
so my 2 question are:
|
I'll run some asvs before long. I'd like to clear up the other cython PRs (especially the fairly easy #22329) before diving into this too deep.
I ran into trouble in converting code in groupby_helper functions, so it definitely isn't trivial. |
asvs for just the reshape functions: These look like noise to me, erring on the side of slightly slower.
|
Closing this proof of concept, first real PR in this process is #22452. |
Low priority after other outstanding cython PRs; will run asvs before long.
Discussed in #22411.