CLN: dedent else part of Series._get_with #22406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
commented
Aug 17, 2018
| @@ -828,47 +828,46 @@ def _get_with(self, key): | |||
| elif isinstance(key, ABCDataFrame): | |||
| raise TypeError('Indexing a Series with DataFrame is not ' | |||
| 'supported, use the appropriate DataFrame column') | |||
| else: | |||
There was a problem hiding this comment.
Git formats the diff below a bit funky, but the red part is a contigous block while the green part is the same block, but dedented.
topper-123
force-pushed
the
clean_Series._get_with
branch
from
de3e551 to
bed8d34
Compare
jreback
requested changes
Aug 17, 2018
pandas/core/series.py
Outdated
| return self._get_values(key) | ||
| else: | ||
| try: | ||
| # handle the dup indexing case (GH 4246) |
There was a problem hiding this comment.
you can remove this else as well
Codecov Report
@@ Coverage Diff @@
## master #22406 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 169 169
Lines 50709 50709
=======================================
Hits 46679 46679
Misses 4030 4030
Continue to review full report at Codecov.
|
topper-123
force-pushed
the
clean_Series._get_with
branch
from
5b92464 to
89fadb0
Compare
gfyoung
added
Internals
jreback
approved these changes
Aug 20, 2018
|
thanks |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThere is a gigantic and unneeded
elseclause inSeries._get_withand it makes the code hard to read.This PR removes the else clause and dedents its content one level. This helps readability.