BUG: Interval scalar arithmetic operations reset closed #22331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
commented
Aug 14, 2018
| @@ -109,79 +109,103 @@ def test_length_errors(self, left, right): | |||
| with tm.assert_raises_regex(TypeError, msg): | |||
| iv.length | |||
|
|
|||
| def test_math_add(self, interval): | |||
There was a problem hiding this comment.
I could have parametrized the interval fixture over closed but it would have blown up a lot of other tests that use this fixture. Wanted this PR to be easy to review, so I only made changes related to the arithmetic operations.
Will clean up these tests as a whole in a follow up. Found a few other bugs when reviewing this code and will want to document/fix those and take them into account prior to cleaning.
jreback
approved these changes
Aug 14, 2018
Codecov Report
@@ Coverage Diff @@
## master #22331 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 169 169
Lines 50706 50706
=======================================
Hits 46691 46691
Misses 4015 4015
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffIncluding this with 0.24.0 for the time being; I think this would be easy to backport into 0.23.5 since this looks to be disjoint from the other interval related changes but thought it best to play it safe.